Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Refactor core and frameworks to work with presets #4043

Merged
merged 19 commits into from
Sep 3, 2018

Conversation

igor-dv
Copy link
Member

@igor-dv igor-dv commented Aug 19, 2018

Issue: This PR is based on the changes in #4027.

What I did

In order to support a single standard of configuration, I've changed core and frameworks to work with presets.

@storybook-safe-bot
Copy link
Contributor

Fails
🚫

PR is marked with "do not merge", "in progress" labels.

🚫

PR is not labeled with one of: ["cleanup","BREAKING CHANGE","feature request","bug","documentation","maintenance","dependencies:update","dependencies","other"]

Generated by 🚫 dangerJS

…k-core-presets

# Conflicts:
#	app/vue/src/server/options.js
#	lib/core/src/server/config/webpack.config.js
@codecov
Copy link

codecov bot commented Aug 23, 2018

Codecov Report

Merging #4043 into core/presets will decrease coverage by 0.01%.
The diff coverage is 10.75%.

Impacted file tree graph

@@               Coverage Diff                @@
##           core/presets    #4043      +/-   ##
================================================
- Coverage         40.76%   40.74%   -0.02%     
================================================
  Files               485      491       +6     
  Lines              5784     5794      +10     
  Branches            774      779       +5     
================================================
+ Hits               2358     2361       +3     
- Misses             3054     3058       +4     
- Partials            372      375       +3
Impacted Files Coverage Δ
app/html/src/server/options.js 0% <ø> (ø) ⬆️
lib/core/src/server/build-static.js 0% <ø> (ø) ⬆️
app/vue/src/server/options.js 0% <ø> (ø) ⬆️
lib/core/src/server/middleware.js 0% <ø> (ø) ⬆️
app/marko/src/server/options.js 0% <ø> (ø) ⬆️
...b/core/src/server/config/webpack.config.default.js 0% <ø> (ø)
app/react/src/server/options.js 0% <ø> (ø) ⬆️
app/angular/src/server/options.js 0% <ø> (ø) ⬆️
app/svelte/src/server/options.js 0% <ø> (ø) ⬆️
app/polymer/src/server/options.js 0% <ø> (ø) ⬆️
... and 30 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9ddb5a2...ed69634. Read the comment docs.

…k-core-presets

# Conflicts:
#	app/angular/src/server/wrapInitialConfig.js
#	app/polymer/src/server/framework-preset-polymer.js
#	lib/core/src/server/loadCustomBabelConfig.js
…o core/presets-merge-babel-configs

# Conflicts:
#	lib/core/package.json
#	lib/core/src/server/core-preset-dev.js
#	lib/core/src/server/core-preset-prod.js
#	yarn.lock
igor-dv and others added 2 commits September 3, 2018 02:25
@igor-dv igor-dv merged commit fabd718 into core/presets Sep 3, 2018
@igor-dv igor-dv deleted the core/framework-core-presets branch September 3, 2018 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants